Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Op.notStartsWith, Op.notEndsWith and Op.notSubstring #14376

Merged
merged 2 commits into from
Apr 13, 2022

Conversation

ReDemoNBR
Copy link
Contributor

@ReDemoNBR ReDemoNBR commented Apr 13, 2022

Pull Request Checklist

Please make sure to review and check all of these items:

  • Have you added new tests to prevent regressions?
  • Does yarn test or yarn test-DIALECT pass with this change (including linting)?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description Of Change

Issue (feature request by myself): #14375

Closes #14375

Todos

  • Add operators (notStartsWith, notEndsWith and notSubstring)
  • Add tests and ensure no regressions
  • Add documentations

Copy link
Member

@ephys ephys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited your message to mark #14375 as closed by this PR

I would typically be against adding notX versions of operators as you can do { Op.not: Op.startsWith: ... }

But we already have notLike, notILike, and a NOT LIKE b is an actual operator different from NOT (a LIKE b).

I do wish we implemented the new behavior for substring, startsWith, endsWith before extending them. I don't know if we'll have time to do that breaking change before the release of v7 though.

Note that v7 is close to a stable release (still a few months, but close), so v6 is considered feature frozen as much as possible. This will only release with v7

All that being said, this looks good to me. Thank you :)

@ephys ephys changed the title PR for issue #14375 (new operators notStartsWith, notEndsWith and notSubstring) feat: Add Op.notStartsWith, Op.notEndsWith and Op.notSubstring Apr 13, 2022
@ephys ephys merged commit 1261e37 into sequelize:main Apr 13, 2022
@github-actions
Copy link
Contributor

🎉 This PR is included in version 7.0.0-alpha.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

vanthome pushed a commit to vanthome/sequelize that referenced this pull request Jun 12, 2022
…equelize#14376)

Co-authored-by: San 'rdn' Mônico <san@monico.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] new operators: notStartsWith, notEndsWith and notSubstring
2 participants