Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing bulkDelete typings #14635

Open
2 of 7 tasks
ghnoob opened this issue Jun 14, 2022 · 0 comments
Open
2 of 7 tasks

Missing bulkDelete typings #14635

ghnoob opened this issue Jun 14, 2022 · 0 comments
Labels
hacktoberfest type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense. v6

Comments

@ghnoob
Copy link

ghnoob commented Jun 14, 2022

Issue Creation Checklist

[x] I have read the contribution guidelines

Issue Description

According to the documentation, the queryBuilder.bulkDelete method accepts the boolean values truncate, cascade and restartIdentity in the options arguments. But this is not reflected in Typescript.

A BulkDeleteOptions interface extending QueryOptions with the parameters truncate, cascade and restartIdentity should be added.

A PR regarding this issue (#12750) was already submitted but it got closed by a bot.

Additional context

image

image

Issue Template Checklist

Is this issue dialect-specific?

  • No. This issue is relevant to Sequelize as a whole.
  • Yes. This issue only applies to the following dialect(s): XXX, YYY, ZZZ
  • I don't know.

Would you be willing to resolve this issue by submitting a Pull Request?

  • Yes, I have the time and I know how to start.
  • Yes, I have the time but I don't know how to start, I would need guidance.
  • No, I don't have the time, although I believe I could do it if I had the time...
  • No, I don't have the time and I wouldn't even know how to start.
@WikiRik WikiRik self-assigned this Jun 14, 2022
@WikiRik WikiRik added the type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense. label Jun 14, 2022
@WikiRik WikiRik added the v6 label Feb 2, 2024
@WikiRik WikiRik removed their assignment Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense. v6
Projects
None yet
Development

No branches or pull requests

3 participants