feat: support typescript >= 4.5's module resolution #14713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephys
added
the
type: typescript
|
About the testing; should we incorporate various TypeScript configurations in the weekly CI checks that we are planning on doing? |
WikiRik
approved these changes
Jul 3, 2022
|
Yes I think that would be good |
|
🎉 This PR is included in version 7.0.0-alpha.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
See #14610 for details
This PR is that PR, but with the last change request applied.
Closes #14610
How to test this
We don't currently have the infrastructure to test how the different versions & configurations of TypeScript import Sequelize
In the meantime, you can clone github.com/sequelize/sequelize-sscce, update
@sequelize/coreto its latest version, then edit thepackage.jsonconfiguration of@sequelize/coreto apply the changes made toexportsTSC's module resolution option should be set to
nodenext,node12, and/ornode16(node16 replaces node12 in newer versions of TSC)