fix(types): fix TS 4.9 excessive depth error on InferAttributes
(v7)
#15134
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description Of Change
#15133: The latest TS build errors on
InferAttributes
with aType instantiation is excessively deep and possibly infinite.
error. Thankfully the fix is easy: Exclude keys inherited from Model before checking its values to reduce the type depth. Should improve perfs too.No new test needed, but this wasn't caught by our CI yet. Will be once we add TypeScript 4.9
This should also get us ready for TS 4.9, I fixed all new typing issues