New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unify and fix tests queryGenerator.arithmeticQuery
/dropTableQuery
/showIndexesQuery
/describeTableQuery
#15235
Conversation
This reverts commit ff61b38.
queryGenerator.arithmeticQuery/dropTableQuery/showIndexesQuery
queryGenerator.arithmeticQuery/dropTableQuery/showIndexesQuery
queryGenerator.arithmeticQuery
/dropTableQuery
/showIndexesQuery
queryGenerator.arithmeticQuery
/dropTableQuery
/showIndexesQuery
queryGenerator.arithmeticQuery
/dropTableQuery
/showIndexesQuery
/describeTableQuery
I'm looking forward to seeing this merged. It's a good step towards cleaning up our APIs and tests! |
I might probably be missing something, but I think this PR should be good to go for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Up to you if you want to improve the test or not
We'll improve it in a future refactor, for now it should be fine. |
Pull Request Checklist
Description Of Change
This PR unifies and fixes the following
queryGenerator
functions;queryInterface.changeColumns
, fix many bugs withchangeColumn
#14687)queryInterface.changeColumns
, fix many bugs withchangeColumn
#14687)Merge Squash Commit Message Body (for breaking changes)