Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unify and fix tests queryGenerator.arithmeticQuery/dropTableQuery/showIndexesQuery/describeTableQuery #15235

Merged
merged 25 commits into from Nov 16, 2022

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Nov 5, 2022

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

This PR unifies and fixes the following queryGenerator functions;

Merge Squash Commit Message Body (for breaking changes)


BREAKING CHANGE: **ibmi** - dropTableQuery does not accept schema in the options anymore, use a tableName object

@WikiRik WikiRik changed the title meta: unify some queryGenerator tests fix: unify and fix tests queryGenerator.arithmeticQuery/dropTableQuery/showIndexesQuery Nov 5, 2022
@WikiRik WikiRik changed the title fix: unify and fix tests queryGenerator.arithmeticQuery/dropTableQuery/showIndexesQuery fix: unify and fix tests queryGenerator.arithmeticQuery/dropTableQuery/showIndexesQuery Nov 5, 2022
@WikiRik WikiRik changed the title fix: unify and fix tests queryGenerator.arithmeticQuery/dropTableQuery/showIndexesQuery fix: unify and fix tests queryGenerator.arithmeticQuery/dropTableQuery/showIndexesQuery Nov 5, 2022
@WikiRik WikiRik changed the title fix: unify and fix tests queryGenerator.arithmeticQuery/dropTableQuery/showIndexesQuery fix: unify and fix tests queryGenerator.arithmeticQuery/dropTableQuery/showIndexesQuery/describeTableQuery Nov 5, 2022
@ephys
Copy link
Member

ephys commented Nov 9, 2022

I'm looking forward to seeing this merged. It's a good step towards cleaning up our APIs and tests!

@WikiRik
Copy link
Member Author

WikiRik commented Nov 10, 2022

I might probably be missing something, but I think this PR should be good to go for now.
I'll update describeTableQuery with the new extractTableDetails in a different PR.

@WikiRik WikiRik requested a review from ephys November 10, 2022 00:21
@WikiRik WikiRik marked this pull request as ready for review November 10, 2022 14:09
src/dialects/abstract/index.ts Outdated Show resolved Hide resolved
src/dialects/abstract/query-generator.js Show resolved Hide resolved
src/dialects/abstract/query-interface.js Outdated Show resolved Hide resolved
src/dialects/ibmi/query-generator.js Show resolved Hide resolved
test/unit/query-generator/arithmetic-query.test.ts Outdated Show resolved Hide resolved
@WikiRik WikiRik marked this pull request as draft November 16, 2022 12:16
@WikiRik WikiRik marked this pull request as ready for review November 16, 2022 17:04
src/dialects/abstract/query-interface.js Outdated Show resolved Hide resolved
Copy link
Member

@ephys ephys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you if you want to improve the test or not

@WikiRik
Copy link
Member Author

WikiRik commented Nov 16, 2022

We'll improve it in a future refactor, for now it should be fine.

@WikiRik WikiRik merged commit c68f8c8 into main Nov 16, 2022
@WikiRik WikiRik deleted the WikiRik/query-generator-unit-tests-refactor branch November 16, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants