New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: migrate describeTableQuery
and showIndexesQuery
to TS
#15299
Conversation
@ephys could you already take a look at this before I do the same approach for some other queryGenerator functions? |
I'm not sure if I fixed the failing postgres test correctly, but according to the |
I haven't migrated |
describeTableQuery
and showIndexesQuery
to TS
I need to make further improvements to |
Let's still deprecate it here (but move it to |
I think we should be good for this PR. Future PRs are;
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
Pull Request Checklist
Description Of Change
This PR builds on the new
extractTableDetails
to provide a cleanerdescribeTableQuery
function. Schemas are now tested for all dialects. There is one behaviour change since the previous PR, which is that the schema is only used in the query when it's not the defaultSchema of the dialect. I would like that to be a choice we make throughout the codebase consistently. That is in line with the changes toquoteTable
It also migrates
showIndexesQuery
with a new test for the above mentioned behaviour ofquoteTable
.It also adds that test to
dropTableQuery
and adds the proper infix for thequoteIdentifier
test file name.