-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mysql): support max_execution_time optimizer hint #15341
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking the time to add a new feature to sequelize
I would call the option maxExecutionTimeHintMs
instead of maxExecutionTimeMs
. It's likely that we'll add a feature that enforces a max execution time that works in all dialects and I don't know yet how compatible it would be with the hint from mysql.
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience
@ephys Is there a problem that we can't merge this? |
Can you resolve the merge conflicts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'll give @ephys some time to look at it as well
@WikiRik Is there any problem with this PR? If there is no plan to merge, I will close it. |
@SeongJaeSong thanks for the reminder! If you can resolve the merge conflicts I think we can merge this in |
Pull Request Checklist
Relates issue
#15173