feat(types): use retry-as-promised types for retry options to match documentation

[esetnik]

Pull Request Checklist

• Did you update the typescript typings accordingly (if applicable)?
• Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
• Does the name of your PR follow our conventions?

Description Of Change

I have corrected the types in the underlying retry-as-promised library so they can now be re-exported by sequelize to get the proper type for retry.

See DefinitelyTyped/DefinitelyTyped#63267 for details.

[WikiRik]

There are a few small differences between the current state and the types package but I do think we should prefer the types package over our own type. Thanks for this PR!

[esetnik]

There are a few small differences between the current state and the types package but I do think we should prefer the types package over our own type. Thanks for this PR!

Yes there are. My hope is that this is not a breaking change for anyone. I'm happy to open a new PR against @types/retry-as-promised for any additional type changes that are necessary, but we would need to audit the underlying package to determine if those modifications are actually valid.

[ephys]

🚀🎉

[esetnik]

Note that @mickhansen is going to refactor retry-as-promised to typescript so we can hold off on merging this PR. I will update this PR to depend on the new version of retry-as-promised with native types once it has been released.

[esetnik]

Waiting on mickhansen/retry-as-promised#37

[ephys]

If tests are green, we're good to go :)

[esetnik]

@ephys will this get a backport release to v6?

[WikiRik]

@esetnik we should be able to, can you open a new PR towards the v6 branch?