Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unshadow model attributes #15480

Merged
merged 2 commits into from Dec 18, 2022
Merged

fix: unshadow model attributes #15480

merged 2 commits into from Dec 18, 2022

Conversation

ephys
Copy link
Member

@ephys ephys commented Dec 18, 2022 •
edited

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Almost Closes #14300, will need to backport to v6

Description Of Change

This PR fixes #14300, all details are in the diff & linked issue :)

@ephys ephys self-assigned this Dec 18, 2022
WikiRik
WikiRik approved these changes Dec 18, 2022
View reviewed changes
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, but it looks good to me. Nice that we can solve this issue in v7

test/registerEsbuild.js Show resolved Hide resolved
@ephys ephys merged commit bb4d401 into main Dec 18, 2022
@ephys ephys deleted the ephys/unshadow-attributes branch December 18, 2022 21:14
@ephys ephys changed the title feat: unshadow model attributes fix: unshadow model attributes Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WikiRik WikiRik WikiRik approved these changes

Assignees

@ephys ephys

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to fix the incompatibility with Public Class Fields
2 participants
@ephys @WikiRik