Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Bulk Update failure when virtual attributes and getDataValue are involved #15741

Merged
merged 19 commits into from
Jun 18, 2023
Merged

fix: Bulk Update failure when virtual attributes and getDataValue are involved #15741

merged 19 commits into from
Jun 18, 2023

Conversation

Mhashh
Copy link
Contributor

@Mhashh Mhashh commented Mar 5, 2023

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

@Mhashh Mhashh changed the title Fixes Bulk Update failure when virtual attributes and getDataValue are involved fix : Bulk Update failure when virtual attributes and getDataValue are involved Mar 5, 2023
@Mhashh Mhashh changed the title fix : Bulk Update failure when virtual attributes and getDataValue are involved fix: Bulk Update failure when virtual attributes and getDataValue are involved Mar 5, 2023
@Mhashh Mhashh marked this pull request as ready for review March 5, 2023 09:49
@Mhashh Mhashh mentioned this pull request Mar 6, 2023
Open
5 tasks
@WikiRik WikiRik requested a review from ephys March 14, 2023 08:47
ephys
ephys requested changes Mar 15, 2023
View reviewed changes
packages/core/src/model.js Outdated Show resolved Hide resolved
packages/core/src/model.js Outdated Show resolved Hide resolved
packages/core/src/model.js Outdated Show resolved Hide resolved
@Mhashh
Copy link
Contributor Author

Mhashh commented Mar 19, 2023

I have remove the changes in model and kept the test only.

@ephys ephys requested a review from a team March 24, 2023 10:12
@ephys ephys enabled auto-merge June 18, 2023 13:34
@ephys ephys added this pull request to the merge queue Jun 18, 2023
Merged via the queue into sequelize:main with commit f5a8815 Jun 18, 2023
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WikiRik WikiRik WikiRik left review comments

@ephys ephys ephys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bulk Update fail seemingly when getDataValue is involved
3 participants
@Mhashh @ephys @WikiRik