Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(postgres): Escape identifier in createSchema and dropSchema #15752

Merged
merged 1 commit into from
Mar 9, 2023
Merged

fix(postgres): Escape identifier in createSchema and dropSchema #15752

merged 1 commit into from
Mar 9, 2023

Conversation

meyfa
Copy link

@meyfa meyfa commented Mar 9, 2023

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

Fixes #15651. This patch backports a part of #14999 to Sequelize v6 to quote schema identifiers in PostgreSQL createSchema() and dropSchema().

Todos

(none)

@meyfa
fix(postgres): Escape identifier in createSchema and dropSchema
9d9dbcf 
Fixes sequelize#15651. This patch backports a part of sequelize#14999 to Sequelize v6 to
quote schema identifiers in PostgreSQL `createSchema()` and
`dropSchema()`.
@meyfa meyfa mentioned this pull request Mar 9, 2023
Closed
6 tasks
ephys
ephys approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@ephys ephys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

WikiRik
WikiRik approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, easy fix but looks good to me

@WikiRik WikiRik merged commit 1ad9a64 into sequelize:v6 Mar 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

🎉 This PR is included in version 6.29.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ephys ephys ephys approved these changes

@WikiRik WikiRik WikiRik approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@meyfa @ephys @WikiRik