Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix unnamed dollar string detection (v7) #15758

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

ephys
Copy link
Member

@ephys ephys commented Mar 10, 2023

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

Fixes an issue reported here: #15301 (comment)

Basically unnamed $$ quoted strings were ending too quickly. The parser considered the string to be delimited like this:

SELECT $$ id $$
--     ^ start of string
--      ^ end of string

instead of this:

SELECT $$ id $$
--     ^ start of string
--           ^ end of string

@ephys ephys changed the title fix: fix unnamed dollar string detection fix: fix unnamed dollar string detection (v7) Mar 10, 2023
@ephys ephys merged commit b2fe30f into main Mar 10, 2023
@ephys ephys deleted the ephys/15301-fix-34332-detection branch March 10, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants