Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restrict precision option in DATE and TIME to number #15800

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Mar 16, 2023

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

Hopefully unblocks #15799 by restricting the precision option to number | undefined

@WikiRik WikiRik requested a review from ephys March 16, 2023 21:33
@WikiRik WikiRik marked this pull request as ready for review March 16, 2023 21:53
@ephys
Copy link
Member

ephys commented Mar 16, 2023

In the title, did you mean "to number" instead of "to string"?

@WikiRik WikiRik changed the title fix: restrict precision option in DATE and TIME to string fix: restrict precision option in DATE and TIME to number Mar 16, 2023
@WikiRik
Copy link
Member Author

WikiRik commented Mar 16, 2023

In the title, did you mean "to number" instead of "to string"?

Yes, and in the description as well. Good that you noticed!

@WikiRik WikiRik merged commit 7bd5907 into main Mar 16, 2023
@WikiRik WikiRik deleted the WikiRik/strict-precision branch March 16, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants