Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type QueryGenerator.dropForeignKeyQuery and add tests #15807

Merged
merged 4 commits into from
Mar 24, 2023

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Mar 19, 2023

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

I noticed in #15454 that the dropForeignKeyQuery for DB2 was not working at all. This PR types that function, fixes it for DB2 and adds tests for it.

@evanrittenhouse
Copy link
Member

Nice find - LGTM, will approve when marked ready for review

@WikiRik WikiRik marked this pull request as ready for review March 19, 2023 21:54
@WikiRik WikiRik merged commit 0435174 into main Mar 24, 2023
@WikiRik WikiRik deleted the WikiRik/drop-foreign-key-query-tests branch March 24, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants