Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove undefined options in sequelize.define #15817

Merged
merged 3 commits into from
Mar 24, 2023
Merged

fix: remove undefined options in sequelize.define #15817

merged 3 commits into from
Mar 24, 2023

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Mar 21, 2023

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

This fixes #15816 but I'm open for suggestions if this is the proper approach. It also migrates test/unit/model/define to TS

@WikiRik WikiRik marked this pull request as ready for review March 21, 2023 20:04
@WikiRik WikiRik requested a review from a team March 21, 2023 20:04
packages/core/src/model-definition.ts Outdated Show resolved Hide resolved
packages/core/src/model-definition.ts Outdated Show resolved Hide resolved
@WikiRik WikiRik requested a review from ephys March 24, 2023 13:38
@WikiRik WikiRik merged commit 6b61ddf into main Mar 24, 2023
@WikiRik WikiRik deleted the WikiRik/15816 branch March 24, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model definition not respecting default schema in the presence of undefined schema passed in
2 participants