-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add queryInterface.withoutForeignKeyChecks
, sequelize.destroyAll
#15842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
5 tasks
ephys
changed the title
feat: add
feat: add Mar 25, 2023
queryInterface,withoutForeignKeyChecks
, sequelize.destroyAll
queryInterface.withoutForeignKeyChecks
, sequelize.destroyAll
WikiRik
reviewed
Mar 26, 2023
WikiRik
approved these changes
Apr 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description Of Change
I needed a way to delete all rows from all tables between tests for #15840.
TRUNCATE
is not a viable solution when the table is referenced by other tables (even if they're empty) in some dialects.This PR:
sequelize.truncate
for mysql, sqlite, mariadb via the a option:withoutForeignKeyChecks
queryInterface
:withoutForeignKeyChecks
, which can be used to temporarily disable foreign keys for a given connection.sequelize.destroyAll
which can be used as an alternative tosequelize.truncate
, as it can handle foreign keys.Model.tableName
transaction.connection
hard private with a gettersetTransactionFromCls
to make it synchronise thetransaction
andconnection
parameters when possible. This makes designing APIs that use these two easier. You can now specify both as long as they are compatible.disableDatabaseResetForSuite
&enableTruncateDatabaseForSuite
withsetResetMode
TODO
delete-schema
,truncate
,destroy
andnone
sequelize.withConnection((connection) => {})
) #15388