Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add beforePoolAcquire and afterPoolAcquire hooks #15874

Merged
merged 4 commits into from
Apr 9, 2023
Merged

feat: add beforePoolAcquire and afterPoolAcquire hooks #15874

merged 4 commits into from
Apr 9, 2023

Conversation

FilipHavel
Copy link
Contributor

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

Link to issue: #15724

@FilipHavel
Copy link
Contributor Author

Hi @ephys, PR for v6 is here. 🎉 Some steps failed on yarn install or are flaky, but changes should be okay. 😊

@ephys ephys changed the title feat(poolacquirehooks): added before / afterPoolAcquire hooks into v6 feat: add before / afterPoolAcquire hooks Apr 1, 2023
ephys
ephys previously requested changes Apr 1, 2023
View reviewed changes
Copy link
Member

@ephys ephys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small documentation change but otherwise ready! Thanks :)

src/sequelize.d.ts Outdated Show resolved Hide resolved
src/sequelize.d.ts Outdated Show resolved Hide resolved
@FilipHavel FilipHavel requested a review from ephys April 6, 2023 11:17
@WikiRik WikiRik changed the title feat: add before / afterPoolAcquire hooks feat: add beforePoolAcquire and afterPoolAcquire hooks Apr 9, 2023
@WikiRik WikiRik dismissed ephys’s stale review April 9, 2023 20:22

Description updated

@WikiRik WikiRik merged commit f2a4535 into sequelize:v6 Apr 9, 2023
48 of 49 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2023

🎉 This PR is included in version 6.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WikiRik WikiRik WikiRik approved these changes

@ephys ephys Awaiting requested review from ephys

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@FilipHavel @ephys @WikiRik @Filip-Havel