fix: deprecate setting quoteIdentifiers to false #15879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephys
reviewed
Apr 1, 2023
ephys
approved these changes
Apr 1, 2023
|
Don't forget to document it in our upgrade guide, under deprecated APIs |
WikiRik
added a commit
to sequelize/website
that referenced
this pull request
Apr 2, 2023
WikiRik
added a commit
to sequelize/website
that referenced
this pull request
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description Of Change
This should deprecate setting
quoteIdentifiersto false so it can be removed in v8, together with the current tests for it. Tests with it that currently exist in dialect specific QueryGenerator unit tests will not be unified in future PRs.