Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: add ibmi smoke tests to CI #15880

Closed
wants to merge 2 commits into from
Closed

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Mar 30, 2023

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

Rework of #14432
Closes #14432

Future PRs should see if we could split install-and-build from here and have a template action in both CI and this workflow.

Todos

  • Do we want to run this on both Node 14 and Node 18?
  • Do we need to rework the smoke test file as well before merging this?

@ephys
Copy link
Member

ephys commented Mar 31, 2023

Do we want to run this on both Node 14 and Node 18?

Probably not considering how incredibly slow it is

@WikiRik
Copy link
Member Author

WikiRik commented Apr 30, 2023

This PR is on hold for now until we hear from Mark about the IBMI_CONN_STR value since we cannot retrieve it from GitHub itself and without it I can't do testing without committing which adds too much overhead to development

needs: [ install-and-build ]
env:
DIALECT: ibmi
SEQ_IBMI_CONN_STR: ${{ secrets.IBMI_CONN_STR }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markdirish do you remember what IBMI_CONN_STR you sent to Sascha on Slack? We don't have enough history going back to that and without it getting this to work is difficult. Feel free to reach out to me on Slack

@ephys
Copy link
Member

ephys commented Feb 11, 2024

Are smoke tests something we still want to do?

@WikiRik
Copy link
Member Author

WikiRik commented Feb 11, 2024

Imo yes, I actually signed up for an account at pub400 recently and will be trying that out soon

@WikiRik WikiRik self-assigned this Apr 12, 2024
@WikiRik
Copy link
Member Author

WikiRik commented Apr 16, 2024

I found a message back from Mark earlier (can't find it now, so not linking it). He mentioned a server from Germany already where it took 8 minutes to run a single test. This is most likely the same server as pub400 so I'm closing this.
If we want to revisit this later; I do have the credentials for a working account

@WikiRik WikiRik closed this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants