Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqlite): don't use mkdirp if the file already exists #15909

Merged
merged 1 commit into from
Apr 9, 2023
Merged

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Apr 9, 2023

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

On Windows, using fs.mkdir() on the root directory even with recursion will result in an error

https://nodejs.org/dist/latest-v16.x/docs/api/fs.html#fsmkdirpath-options-callback

Fixes #14555

@WikiRik WikiRik requested a review from a team April 9, 2023 14:48
@evanrittenhouse
Copy link
Member

LGTM! Nice find

@WikiRik WikiRik merged commit f5bbd6b into main Apr 9, 2023
48 checks passed
@WikiRik WikiRik deleted the 14555 branch April 9, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants