Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): remove escape from query-interface types #15944

Merged
merged 3 commits into from Jul 6, 2023

Conversation

spearmootz
Copy link
Contributor

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • [x ] If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • [x ] Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • [ x] Does the name of your PR follow our conventions?

Description Of Change

according to typeings sequelize.queryInterface.escape exists, when in fact it does not.

on a different note, this exists sequelize.queryInterface.queryGenerator.escape but the types says it does not but thats more undersandable

Todos

no TODOS unless we want to test for something not being there

@WikiRik WikiRik added the v6 label May 24, 2023
@WikiRik WikiRik changed the title fix(type): remove escape from query-interface types fix(types): remove escape from query-interface types Jul 6, 2023
@WikiRik WikiRik enabled auto-merge (squash) July 6, 2023 19:55
@WikiRik WikiRik merged commit 2eb7a5d into sequelize:v6 Jul 6, 2023
49 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

🎉 This PR is included in version 6.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants