Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate describeTable to typescript #15945

Merged
merged 7 commits into from
Jun 18, 2023
Merged

feat: migrate describeTable to typescript #15945

merged 7 commits into from
Jun 18, 2023

Conversation

lohart13
Copy link
Contributor

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

Migrated describeTable to typescript.

@lohart13 lohart13 force-pushed the feat-describeTable-typescript branch from 62eff65 to 20947ea Compare April 25, 2023 20:46
ephys
ephys previously requested changes Apr 28, 2023
View reviewed changes
Copy link
Member

@ephys ephys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few notes but good work :)

packages/core/src/dialects/abstract/query-interface-typescript.ts Outdated Show resolved Hide resolved
packages/core/src/dialects/abstract/query-interface-typescript.ts Outdated Show resolved Hide resolved
packages/core/src/dialects/abstract/query-interface-typescript.ts Outdated Show resolved Hide resolved
@lohart13 lohart13 force-pushed the feat-describeTable-typescript branch from 372c358 to 4121ca5 Compare April 28, 2023 09:27
WikiRik
WikiRik reviewed Apr 28, 2023
View reviewed changes
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Zoé, nice work! I have one small question

packages/core/src/dialects/abstract/query-interface.types.ts Show resolved Hide resolved
@lohart13
Copy link
Contributor Author

Thanks @WikiRik,

Please see my comments above.
Trust this makes sense.

WikiRik
WikiRik previously approved these changes Apr 28, 2023
View reviewed changes
@lohart13 lohart13 requested a review from ephys April 28, 2023 10:15
@ephys ephys dismissed their stale review June 17, 2023 19:54

PR ready

@lohart13 lohart13 force-pushed the feat-describeTable-typescript branch from a58b7a4 to 4fb70ae Compare June 18, 2023 06:57
@ephys ephys added this pull request to the merge queue Jun 18, 2023
Merged via the queue into sequelize:main with commit 37bff7e Jun 18, 2023
47 checks passed
@lohart13 lohart13 deleted the feat-describeTable-typescript branch June 18, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ephys ephys ephys approved these changes

@WikiRik WikiRik WikiRik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lohart13 @ephys @WikiRik