Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): wrong generic type for changed() #16047

Merged
merged 3 commits into from
Jun 17, 2023
Merged

fix(types): wrong generic type for changed() #16047

merged 3 commits into from
Jun 17, 2023

Conversation

Synthetic-Dev
Copy link
Contributor

@Synthetic-Dev Synthetic-Dev commented May 22, 2023 •
edited

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

Closes #16046
Changed the generic type definition for Model.changed() to use keyof TModelAttributes from keyof this

Todos

N/a

@WikiRik WikiRik requested a review from ephys May 24, 2023 20:19
ephys
ephys approved these changes Jun 17, 2023
View reviewed changes
Copy link
Member

@ephys ephys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch :)

@ephys ephys enabled auto-merge (squash) June 17, 2023 13:38
@ephys ephys merged commit fad20ee into sequelize:main Jun 17, 2023
47 checks passed
@MaksymAleieiv MaksymAleieiv mentioned this pull request Jan 12, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ephys ephys ephys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incorrect generic type for changed()
2 participants
@Synthetic-Dev @ephys