-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mariadb): drop 10.3 and add 11.0 support #16133
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WikiRik
commented
Jun 16, 2023
This was referenced Jun 16, 2023
ephys
requested changes
Jun 17, 2023
It seems that the following test is not flaky, but just broken for MariaDB 11.0;
|
Let's update the connector and see if that has a positive impact on the test. Unlikely but who knows |
The connector upgrade seems to have done the trick, not sure why though. We'll have to keep looking out for this test if it fails again in the future |
ephys
approved these changes
Jun 18, 2023
I'll let you merge for the breaking change info in the commit message |
WikiRik
changed the title
meta(mariadb): drop 10.3 and add 11.0 support
feat(mariadb): drop 10.3 and add 11.0 support
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description Of Change
MariaDB 10.3 is EOL since May 25th; https://mariadb.org/about/#maintenance-policy
The reason why the lowest version is MariaDB 10.4.6 is because that is the first stable release of 10.4 and the first that has the mariadb commands symlinked