Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mariadb): drop 10.3 and add 11.0 support #16133

Merged
merged 9 commits into from
Jun 19, 2023
Merged

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Jun 16, 2023

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

MariaDB 10.3 is EOL since May 25th; https://mariadb.org/about/#maintenance-policy
The reason why the lowest version is MariaDB 10.4.6 is because that is the first stable release of 10.4 and the first that has the mariadb commands symlinked

@WikiRik WikiRik marked this pull request as ready for review June 16, 2023 15:29
@WikiRik WikiRik marked this pull request as draft June 16, 2023 15:29
dev/mariadb/oldest/docker-compose.yml Outdated Show resolved Hide resolved
packages/core/test/integration/json.test.ts Outdated Show resolved Hide resolved
@WikiRik WikiRik marked this pull request as ready for review June 18, 2023 10:32
@WikiRik WikiRik requested a review from ephys June 18, 2023 10:32
@WikiRik WikiRik marked this pull request as draft June 18, 2023 11:37
@WikiRik
Copy link
Member Author

WikiRik commented Jun 18, 2023

It seems that the following test is not flaky, but just broken for MariaDB 11.0;

  1) [MARIADB] Model
       findAll
         groupedLimit
           on: belongsToMany
             [Flaky] works with computed order:

      AssertionError: expected [ 1, 3, 5, 4, 7 ] to deeply equal [ 1, 3, 5, 4 ]
      + expected - actual

         1
         3
         5
         4
      -  7
       ]

@ephys
Copy link
Member

ephys commented Jun 18, 2023

Let's update the connector and see if that has a positive impact on the test. Unlikely but who knows

@WikiRik WikiRik marked this pull request as ready for review June 18, 2023 18:34
@WikiRik
Copy link
Member Author

WikiRik commented Jun 18, 2023

The connector upgrade seems to have done the trick, not sure why though. We'll have to keep looking out for this test if it fails again in the future

@ephys
Copy link
Member

ephys commented Jun 18, 2023

I'll let you merge for the breaking change info in the commit message

@WikiRik WikiRik changed the title meta(mariadb): drop 10.3 and add 11.0 support feat(mariadb): drop 10.3 and add 11.0 support Jun 19, 2023
@WikiRik WikiRik merged commit 64e392d into main Jun 19, 2023
50 checks passed
@WikiRik WikiRik deleted the WikiRik/mariadb-updates branch June 19, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants