-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mssql): return aggregated error instead of last error #16188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general. Would it be possible to add a test that checks for the other errors as well to make sure it's not giving back random messages/errors?
a01195b
to
6160c9d
Compare
@WikiRik I've added some more tests now. All other errors with either return an |
packages/core/test/integration/dialects/mssql/query-error.test.ts
Outdated
Show resolved
Hide resolved
3c02430
to
df2670b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a few instances where you can better use backticks for strings so you have less instances of escaping single quotes, but I want to look for a eslint rule to fix that so it's fine here
@ephys might have some suggestions for using decorators in the tests, but we haven't made a clear policy on that yet (or given some guidelines in CONTRIBUTING docs)
df2670b
to
57704b7
Compare
I'll merge this anyway, but @ephys feel free to still comment on usages of decorators in tests later |
Pull Request Checklist
Description Of Change
Return aggregated for MSSQL when the error object as an
error.errors
length greater than 0.