Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sqlite): split SQLite from MySQL #16201

Merged
merged 3 commits into from
Jul 1, 2023
Merged

feat(sqlite): split SQLite from MySQL #16201

merged 3 commits into from
Jul 1, 2023

Conversation

lohart13
Copy link
Contributor

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

This PR splits SQLite from MySQL dialect so all methods are unique to each dialect.
Also, this PR remove support for some unsupported SQLite methods.

@lohart13 lohart13 mentioned this pull request Jun 28, 2023
Merged
5 tasks
@WikiRik WikiRik requested a review from ephys June 28, 2023 06:09
@WikiRik WikiRik added this pull request to the merge queue Jul 1, 2023
Merged via the queue into sequelize:main with commit 789b690 Jul 1, 2023
47 checks passed
@lohart13 lohart13 deleted the split-sqlite branch July 2, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WikiRik WikiRik WikiRik approved these changes

@ephys ephys Awaiting requested review from ephys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lohart13 @WikiRik