Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support array of tableHints and allow joins to use tableHints #16242

Merged
merged 5 commits into from
Jul 19, 2023
Merged

fix: support array of tableHints and allow joins to use tableHints #16242

merged 5 commits into from
Jul 19, 2023

Conversation

lohart13
Copy link
Contributor

@lohart13 lohart13 commented Jul 7, 2023

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

This PR allows for an array of tableHints to be passed to a query and also allows for any joins to also have the tableHints applied.

As part of this, I have moved the logic for adding index & table hints to quoteTable as they need to be appended after table name in the query.

@WikiRik WikiRik requested a review from a team July 7, 2023 10:48
WikiRik
WikiRik previously approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments but non blocking

packages/core/test/unit/query-generator/select-query.test.ts Outdated Show resolved Hide resolved
packages/core/test/unit/query-generator/select-query.test.ts Outdated Show resolved Hide resolved
@WikiRik WikiRik requested a review from ephys July 7, 2023 13:38
@WikiRik WikiRik changed the title fix: index and table hints fix: support array of tableHints and allow joins to use tableHints Jul 19, 2023
@WikiRik WikiRik added this pull request to the merge queue Jul 19, 2023
Merged via the queue into sequelize:main with commit c081850 Jul 19, 2023
50 checks passed
@lohart13 lohart13 deleted the fix-tablehints branch July 19, 2023 08:49
@hsource hsource mentioned this pull request Jan 27, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WikiRik WikiRik WikiRik approved these changes

@ephys ephys Awaiting requested review from ephys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lohart13 @WikiRik