-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ibmi): reconnect when connection drops because of 08S01 error #16259
Conversation
I guess some sort of test would be much appreciated :) |
I'd be happy to add them but I don't see any unit tests even started for the ibm i... |
Unit tests are ran by the CI, using |
With a change like this, is it the assumption I need to start creating the integration tests for this to get merged? |
It would be nice if you could add a test so we can have an idea when this issue would occur and be fixed by this. Although we wouldn't actually be able to test it since we do not have access to an instance but we would at least have a general idea for the future |
A test would have been nice, but I looked into it and it should be fine. Like I mentioned before; it's not like the test would get ran anyway |
Pull Request Checklist
Tested via add a retry block on the Sequelize config locally and verified change allows connection to be re-established.
Description Of Change
Changes here include a way to get sequelize when the IBM i connection drops. This change checks a specific SQL state on the IBM i and utilizes the ConnectionRefusedError to trigger a reconnect.