Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate tableExists to typescript #16320

Merged
merged 7 commits into from
Jul 28, 2023

Conversation

lohart13
Copy link
Contributor

@lohart13 lohart13 commented Jul 26, 2023

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

Migrates tableExists and tableExistsQuery to typescript.

For some reason the foreign key check in the alter method for the Model class needed to have the tableCatalog condition updated so that it only checks the value is its returned by the getForeignKeyReferencesForTable query.

Todos

@lohart13
Copy link
Contributor Author

lohart13 commented Jul 26, 2023

The db2 tests won't pass until #16307 has been merged as this PR updates the default schema value which is need for the queries to be correct.

lohart13 and others added 2 commits July 28, 2023 20:17
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
@WikiRik WikiRik enabled auto-merge July 28, 2023 08:26
@WikiRik WikiRik added this pull request to the merge queue Jul 28, 2023
Merged via the queue into sequelize:main with commit 5167e88 Jul 28, 2023
49 checks passed
@lohart13 lohart13 deleted the table-exists-typescript branch July 29, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants