-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate tableExists to typescript #16320
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
The db2 tests won't pass until #16307 has been merged as this PR updates the default schema value which is need for the queries to be correct. |
Not every getForeignKeyReferencesForTable query returns a value for tableCatalog.
lohart13
force-pushed
the
table-exists-typescript
branch
from
July 27, 2023 22:15
4aa2b6c
to
a78e26b
Compare
WikiRik
reviewed
Jul 28, 2023
packages/core/src/dialects/sqlite/query-generator-typescript.ts
Outdated
Show resolved
Hide resolved
packages/core/src/dialects/abstract/query-interface-typescript.ts
Outdated
Show resolved
Hide resolved
packages/core/src/dialects/abstract/query-generator-typescript.ts
Outdated
Show resolved
Hide resolved
packages/core/test/unit/query-generator/table-exists-query.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Rik Smale <13023439+WikiRik@users.noreply.github.com>
WikiRik
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description Of Change
Migrates
tableExists
andtableExistsQuery
to typescript.For some reason the foreign key check in the
alter
method for theModel
class needed to have the tableCatalog condition updated so that it only checks the value is its returned by thegetForeignKeyReferencesForTable
query.Todos