Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript 5.2 support #16414

Closed
4 of 8 tasks
esetnik opened this issue Aug 24, 2023 · 13 comments
Closed
4 of 8 tasks

Typescript 5.2 support #16414

esetnik opened this issue Aug 24, 2023 · 13 comments
Labels
released type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense. v6

Comments

@esetnik
Copy link
Contributor

esetnik commented Aug 24, 2023

Issue Creation Checklist

  • I understand that my issue will be automatically closed if I don't fill in the requested information
  • I have read the contribution guidelines

Feature Description

Describe the feature you'd like to see implemented

node_modules/sequelize/types/transaction.d.ts:121:13 - error TS2395: Individual declarations in merged declaration 'LOCK' must be all exported or all local

Describe why you would like this feature to be added to Sequelize

The latest version of typescript 5.2 was released and sequelize is not compatible

Is this feature dialect-specific?

  • No. This feature is relevant to Sequelize as a whole.
  • Yes. This feature only applies to the following dialect(s):

Would you be willing to resolve this issue by submitting a Pull Request?

  • Yes, I have the time and I know how to start.
  • Yes, I have the time but I will need guidance.
  • No, I don't have the time, but my company or I are supporting Sequelize through donations on OpenCollective.
  • No, I don't have the time, and I understand that I will need to wait until someone from the community or maintainers is interested in implementing my feature.

Indicate your interest in the addition of this feature by adding the 👍 reaction. Comments such as "+1" will be removed.

@esetnik esetnik added pending-approval Bug reports that have not been verified yet, or feature requests that have not been accepted yet type: feature For issues and PRs. For new features. Never breaking changes. labels Aug 24, 2023
@WikiRik
Copy link
Member

WikiRik commented Aug 24, 2023

You're quick! I'm assuming this is for v6 right? Since our typing tests for main pass for TypeScript 5.2 (see #16412 )

@esetnik
Copy link
Contributor Author

esetnik commented Aug 24, 2023

Yes, for v6 👍 . I see that it is already fixed in v7 alpha.

@WikiRik WikiRik added v6 type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense. and removed pending-approval Bug reports that have not been verified yet, or feature requests that have not been accepted yet type: feature For issues and PRs. For new features. Never breaking changes. labels Aug 24, 2023
@WikiRik
Copy link
Member

WikiRik commented Aug 24, 2023

I just noticed that you're willing to submit a PR, go for it! Do also update the following line to include 4.9, 5.0, 5.1 and 5.2;

ts-version: ["4.1", "4.2", "4.3", "4.4", "4.5", "4.6", "4.7", "4.8"]

@esetnik
Copy link
Contributor Author

esetnik commented Aug 25, 2023

@WikiRik do you plan to release more versions of v6 if I am able to fix the issue?

@WikiRik
Copy link
Member

WikiRik commented Aug 25, 2023

@WikiRik do you plan to release more versions of v6 if I am able to fix the issue?

Yes, every merged PR towards the v6 branch triggers a release

@avifatal
Copy link

avifatal commented Aug 27, 2023

Hi,
This is my package.json:

 "dependencies": 
    "@nestjs/common": "10.1.3",
    "@nestjs/config": "^3.0.0",
    "@nestjs/core": "10.1.3",
    "@nestjs/sequelize": "^10.0.0",
    "sequelize-typescript": "^2.1.5",
    "sequelize": "^6.32.1",

  },
  "devDependencies": {
    "typescript": "^5.2.0"
  }

how can I resolve for now the error...
becuse "typescript": "^5.1.0" also fails.
Thaks

@Marocco2
Copy link

Hi, This is my package.json:

 "dependencies": 
    "@nestjs/common": "10.1.3",
    "@nestjs/config": "^3.0.0",
    "@nestjs/core": "10.1.3",
    "@nestjs/sequelize": "^10.0.0",
    "sequelize-typescript": "^2.1.5",
    "sequelize": "^6.32.1",

  },
  "devDependencies": {
    "typescript": "^5.2.0"
  }

how can I resolve for now the error... becuse "typescript": "^5.1.0" also fails. Thaks

set "typescript": "==5.1.0"
then switch back to "typescript": "^5.2.0" only when issue is resolved

@abdullateef97
Copy link

abdullateef97 commented Sep 2, 2023

Hi, This is my package.json:

 "dependencies": 
    "@nestjs/common": "10.1.3",
    "@nestjs/config": "^3.0.0",
    "@nestjs/core": "10.1.3",
    "@nestjs/sequelize": "^10.0.0",
    "sequelize-typescript": "^2.1.5",
    "sequelize": "^6.32.1",

  },
  "devDependencies": {
    "typescript": "^5.2.0"
  }

how can I resolve for now the error... becuse "typescript": "^5.1.0" also fails. Thaks

set "typescript": "==5.1.0" then switch back to "typescript": "^5.2.0" only when issue is resolved

this doesn't work for me

@alejoiglesias
Copy link

Hi, This is my package.json:

 "dependencies": 
    "@nestjs/common": "10.1.3",
    "@nestjs/config": "^3.0.0",
    "@nestjs/core": "10.1.3",
    "@nestjs/sequelize": "^10.0.0",
    "sequelize-typescript": "^2.1.5",
    "sequelize": "^6.32.1",

  },
  "devDependencies": {
    "typescript": "^5.2.0"
  }

how can I resolve for now the error... becuse "typescript": "^5.1.0" also fails. Thaks

set "typescript": "==5.1.0" then switch back to "typescript": "^5.2.0" only when issue is resolved

this doesn't work for me

"typescript": "5.1.6" works for me

@abdullateef97
Copy link

thank you @alejoiglesias this works fine

@esetnik
Copy link
Contributor Author

esetnik commented Sep 5, 2023

This should be fixed once #16442 gets merged and a new v6 release is published

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

🎉 This issue has been resolved in version 6.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mat813
Copy link
Sponsor

mat813 commented Sep 8, 2023

6.33.0 fixes it for me.

@WikiRik WikiRik closed this as completed Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released type: typescript For issues and PRs. Things that involve typescript, such as typings and intellisense. v6
Projects
None yet
Development

No branches or pull requests

7 participants