Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve association decorators #16486

Merged
merged 1 commit into from
Sep 12, 2023
Merged

fix: improve association decorators #16486

merged 1 commit into from
Sep 12, 2023

Conversation

ephys
Copy link
Member

@ephys ephys commented Sep 12, 2023

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

This PR:

  • Forbids specifying the as option at the root of association decorators, because it will be ignored in favor of using the name of the property being decorated
  • Loosens the typing of the @BelongsTo decorator, due to it being incompatible with inheritable models

@ephys ephys added this pull request to the merge queue Sep 12, 2023
Merged via the queue into main with commit b8edd52 Sep 12, 2023
51 checks passed
@ephys ephys deleted the ephys/association-typing branch September 12, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants