fix: prevent public class fields from shadowing association values #16493
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description Of Change
Eager-loaded associations were suffering from the same issue as attributes: they get shadowed by public class fields declared on the model.
This adds a workaround. The actual solution would be to move everything from the constructor inside of the
build
method, so everything can be done after the class properties have been defined instead of before.This will be possible to do in v8 when we ban using "new" on the model and require always using the build static method instead (deprecation warning & TODO are already present)