Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated constraint column order #16614

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

lohart13
Copy link
Contributor

@lohart13 lohart13 commented Oct 8, 2023

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description Of Change

This PR fixes an issue were the ordering of the columns for a constraint is not returned in the same order that they were created in.

I've only updated the unit test the issue is hard to replicate for integration test and we are already checking the column order in these tests via deep.equal

@lohart13
Copy link
Contributor Author

See the latest failure in PR #16227 for an example of the issues.

@WikiRik WikiRik added this pull request to the merge queue Oct 10, 2023
Merged via the queue into sequelize:main with commit dd2aa18 Oct 10, 2023
49 checks passed
@lohart13 lohart13 deleted the fix-constraint-column-order branch October 10, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants