findOrCreate should eagerly load included models.

[JehandadK]

db.User.findOrCreate(
{
name: "kam"
},
{ username: "something", email:"something, age:23 },
{
include: [
{ model: db.Language, as: 'learningLanguage' },
{ model: db.Language, as: 'secondaryLanguage' },
{ model: db.Language, as: 'primaryLanguage' }
]
}).success(function (user, created) {
if (created) res.status(201).json(user);
else res.status(200).json(user);
});

I believe this query should create and retuned included models of Language with it? Am I doing something wrong or this is pending.

[mickhansen]

Not supported at the moment, probably wouldn't be hard to implement.
Would just need to add include: options.include to https://github.com/sequelize/sequelize/blob/master/lib/dao-factory.js#L1026.

PR's always welcome.

[JehandadK]

I have forked and setup tests, they are running fine. Just a word, for this case the Tests would belong to

DAOFactory -> findOrCreate ->

• should create a user that does not exists
• should return a old user that exists
• should return all associated foregin objects with user.
• should return all included objects mentioned in include

Do they seem right?

[mickhansen]

https://github.com/sequelize/sequelize/blob/master/test/dao-factory/create.test.js#L33 ad them here.

Your two first cases should already be covered. I'm not sure what case 3 covers but case 4 seems like what you would want to go with for this feature.

[devilankur18]

+1

[cuva]

+1

[mickhansen]

This should actually be supported since we changed the signature of findOrCreate

[aprilmintacpineda]

@mickhansen can you please give an example of a working code with findOrCreate, mine doesn't work, it creates the record when it does not exists but it does not eagerload the associations specified.

models.Conversation.findOrCreate({
  where: {
    [ Op.or ]: [
      {
        recipient_user_id: request.signedinUser.id,
        sender_user_id: request.body.user_id
      },
      {
        sender_user_id: request.signedinUser.id,
        recipient_user_id: request.body.user_id
      }
    ]
  },
  include: [
    'recipient',
    'sender',
    models.Chat
  ],
  defaults: {
    /* defaults */
  }
})
.spread(conversation => {
  /* will output undefined */
  console.log(conversation.Chats);
  console.log(conversation.sender);
  console.log(conversation.recipient);
  /* will have no Chats, sender or recipient */
  console.log(conversation);
});

Eagerloading associations only works when the record exists.

• sequelize@^4.31.2

[lHumanizado]

I'm having this problem too using v5 beta 15

[ekristen]

Same

[createthis]

me too with 4.42.0

[ccemeraldeyes]

This is still a problem, why is this issue closed?

[papb]

@ccemeraldeyes Can you please provide a SSCCE, many people complained already but no one gave a SSCCE, thanks :)

[createthis]

@papb I created an SSCCE for you to the best of my ability: https://github.com/createthis/sequelize_1711_sscce

[papb]

@createthis Thanks! I will investigate later.

[BOBYZH]

Still a problem for me in 2020...

[vbhakta8]

Did anyone get this working? I see the feature is there but it still doesn't seem to be working?

[github-actions]

This issue has been automatically marked as stale because it has been open for 14 days without activity. It will be closed if no further activity occurs within the next 14 days. If this is still an issue, just leave a comment or remove the "stale" label. 🙂

[santicalcagno]

Still happening, not stale.