meta: fix auto-update failing on forks #17280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephys
changed the title
1 task
WikiRik
approved these changes
Apr 12, 2024
|
lint-staged doesn't work for me either, it runs but it doesn't prevent the commit |
|
@ephys I'll let you merge this one, in case you want to do something additional with this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The API endpoint to update branch does not allow updating branches from forks, even if the PR specifies that maintainers are allowed to push commits on it.
As a solution, forks are now updated via
gitinstead of the GitHub API: https://github.com/sequelize/pr-auto-update-and-handle-conflicts/blob/74929c430b8843e691e7b83d229d8d13d78d89e3/src/action.ts#L331-L398This update operation requires using the PAT of a maintainer instead of a bot as the permissions of the bot do not apply to forks
PR & workflow run showing that this works:
Also, it looks like the changelog deletion still does not work :(