Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set sequelize dialect type in query generator and interface #17285

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

lohart13
Copy link
Contributor

Pull Request Checklist

  • Have you added new tests to prevent regressions?
  • If a documentation update is necessary, have you opened a PR to the documentation repository?
  • Did you update the typescript typings accordingly (if applicable)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Does the name of your PR follow our conventions?

Description of Changes

This PR sets the Sequelize dialect type for the queryGenerator and queryInterface.

Currently the sequelize instance in the queryGenerator and queryInterface uses the AbstractDialect which mean accessing the sequelize.options from inside these classes does not return the correct typed values.

List of Breaking Changes

@lohart13 lohart13 requested a review from a team as a code owner April 15, 2024 06:56
@lohart13 lohart13 requested review from ephys and WikiRik April 15, 2024 06:56
@lohart13 lohart13 changed the title fix(types): set sequelize dialect type in query generator and interface fix: set sequelize dialect type in query generator and interface Apr 15, 2024
Copy link
Member

@ephys ephys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@ephys ephys merged commit 0227288 into sequelize:main Apr 16, 2024
50 checks passed
@lohart13 lohart13 deleted the scope-sequelize branch April 16, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants