Where should not be required in Model#update()

[overlookmotel]

I just noticed that providing a where parameter in the options passed to Model#update() is required. The following throws an error:

Folder.update({name: 'bob'})

This doesn't allow you to update all rows in a table simultaneously, which sometimes you might want to do. Should this be the case?

[overlookmotel]

Of course, you can do:

Folder.update({name: 'bob'}, {where: {}})

My silly.

[janmeier]

Yep, an empty where object was the idea. I made the where required to make the API change

[mickhansen]

It's also a pretty good sanity check.

[gorangajic]

why then throw a new Error?

sequelize/lib/model.js

Line 1584 in 5be3119

throw new Error('Missing where attribute in the options parameter passed to update.');

options = options || {};
options.where = options.where || {};

I can create a pull request if you want?

[gorangajic]

btw this

Folder.update({name: 'bob'}, {where: {}})

does not work for me
stacktrace - https://gist.github.com/feroc1ty/21ed43095bc145c40135

[janmeier]

The where is required to make sure the user actually wants to update all rows

[gorangajic]

query

postgres Executing (default): UPDATE "Users" SET "something"=0,"updatedAt"='2015-02-11 11:54:48.880 +00:00' WHERE

[mickhansen]

@Feroc1ty seems there's an error in the query generator :)
Please open a new issue.