Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(optimistic_locking): fix version update on model decrement #8593

Conversation

ali-essam
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • [y] Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • [y] Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • [y] Have you added new tests to prevent regressions?
  • [n] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • [y] Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Using decrement on model should increment the version instead of decrementing it

Note: Some unrelated tests were failing locally before the changes

@codecov
Copy link

codecov bot commented Nov 4, 2017

Codecov Report

Merging #8593 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@sushantdhiman sushantdhiman merged commit 0047dca into sequelize:master Nov 5, 2017
@ali-essam ali-essam deleted the fix/optimistic-locking-decrement-version branch November 5, 2017 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants