Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query-generator): make it possible to use Op as comparator in Seq… #9124

Merged
merged 1 commit into from Mar 1, 2018

Conversation

jharting
Copy link
Contributor

@jharting jharting commented Mar 1, 2018

…uelize.where (#9123)

Closes #9123

Pull Request check-list

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

make it possible to use Op operators in Sequelize.where, e.g.:

sequelize.where(sequelize.fn('SUM', sequelize.col('price')), Op.gt, 0);

@sushantdhiman sushantdhiman requested a review from a team March 1, 2018 09:40
@codecov
Copy link

codecov bot commented Mar 1, 2018

Codecov Report

Merging #9124 into master will increase coverage by <.01%.
The diff coverage is 100%.

Copy link
Member

@eseliger eseliger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could leave one example in the docs on that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants