fix(model): Made sure errors with messages are passed to AggregateError for bulk creates. #9133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or for bulk creates. Previously objects passed to the AggregateError did not have a message property, causing them to be rendered as [object Object] in the console log. This change fixes the issue of a missing message property fix sequelize#8989
Removed some leftover debugging and update the documentation
…or for bulk creates. Changed the punctuation in a docblock
lib/model.js
Outdated
| * Simply extending the value of `err` would cause a breaking change as the `errors` | ||
| * property is expected on each item in the array of errors. | ||
| */ | ||
| errors.push(new sequelizeErrors.RecordLinkedError(err, instance)); |
There was a problem hiding this comment.
Why not just push validation error
There was a problem hiding this comment.
It would cause a breaking change, a property of record and errors is expected in each item.
There was a problem hiding this comment.
I think we can simply do this
err.record = instance;
errors.push(err);In v5 we can remove record as instance property is already available in ValidationErrorItem
sushantdhiman
approved these changes
Mar 10, 2018
|
🎉 This PR is included in version 4.35.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Hey thanks, sorry I've been afk all week |
This was referenced Mar 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
Previously objects passed to the AggregateError did not have a message property, causing them to be
rendered as [object Object] in the console log. This change fixes the issue of a missing message
property.
fixes #8989