Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The json file is removed when installing a plugin #38

Closed
Seraf opened this issue May 19, 2014 · 3 comments
Closed

The json file is removed when installing a plugin #38

Seraf opened this issue May 19, 2014 · 3 comments
Milestone

Comments

@Seraf
Copy link
Owner

Seraf commented May 19, 2014

On the line https://github.com/Seraf/LISA/blob/master/lisa/server/plugins/PluginManager.py#L115 the json is removed during the plugin install.
It is not a problem on production, but during plugin development it's annoying.
The CLI should take an optionnal argument to know it is a development context and do not delete this json file.
This development argument should also be used to install/uninstall easily the plugin without removing the directory, and playing with pip.

@Seraf Seraf added this to the LISA 1.0 milestone May 19, 2014
@Seraf
Copy link
Owner Author

Seraf commented May 19, 2014

The commit d32a307 should fix the issue.

@gdumee
Copy link

gdumee commented May 20, 2014

I confirm that this issue is fixed
Create : lisa-cli plugin --create <plugin_name>
Install : lisa-cli plugin --install <plugin_name> --dev
Uninstall : lisa-cli plugin --uninstall <plugin_name> --dev

@Seraf
Copy link
Owner Author

Seraf commented May 20, 2014

Thanks for the review :)

@Seraf Seraf closed this as completed May 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants