Make Session.transaction inline

[augustl]

By marking it as an inline function, it becomes possible to use transaction from a coroutine context, without having to any additional sit-ups to make it work.

For example, this code does not work now, but works fine with this patch applied:

withTimeout(1000) {
    async {
        sessionOf(dataSource).use { dbSess ->
            dbSess.transaction { txSess ->
                delay(1000)
                // Without inline, fails with: 
                //     Suspension functions can be called only within coroutine body
                // Works fine when `transaction` is inline
            }
        }
    }
}

As far as I can tell, marking transaction as inline has no negative side effects for the current uses, and should be fully backwards compatible :)

[seratch]

This should be fine but can you add some unit tests that demonstrate the use case for preventing future regressions?

[augustl]

@seratch good point! I just updated the PR with a test verifying it instead of a small blog post explaining it in the commit message :)

[ievgen-kapinos]

Hi @augustl
On my project I've ended up with the same idea. Implemented it locally and it works well!
Thank you for contributing this to the public.

[augustl]

@ievgen-kapinos I've done that too, actually! :) However, I'm writing a book for Apress about Kotlin, and it's using Kotliquery. So a library native solution to the problem is definitely preferred!

[seratch]

Wow, it's so exciting to hear that you are writing a Kotlin book and using this library in the code examples! Cannot wait to read the book!

[seratch]

LGTM

[seratch]

I just released v1.9.0 to the Sonatype OSS repos. Those jar files will be available on Maven Central soon 🚀

[augustl]

Thanks for the merge!

Wow, it's so exciting to hear that you are writing a Kotlin book and using this library in the code examples! Cannot wait to read the book!

Thanks, so am I! :D The book is titled Pro Kotlin Web Apps from Scratch, on Apress, where I teach how to write web apps without a framework. Kotliquery is the number 1 choice for that sort of setup imo, and I've used it in large real-world projects.

[augustl]

The book is out now, btw :)

https://www.amazon.com/Pro-Kotlin-Apps-Scratch-Production-ready/dp/1484290569

[seratch]

@augustl Thank you for sharing this and congratulations on publishing the book!

I've just bought the Kindle version and read Chapter 6. I really appreciate the way you explain the value of a simple SQL database library, like Kotliquery, for web apps. Although I haven't gone through the other chapters in detail yet, I'm thoroughly enjoying the book so far. Thanks again for including this library in your book!

[augustl]

You're welcome! And thanks for making an awesome library :)