Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chrome on iOS (CriOS) detection #72

Closed
peterbo opened this issue Apr 11, 2013 · 4 comments
Closed

Chrome on iOS (CriOS) detection #72

peterbo opened this issue Apr 11, 2013 · 4 comments
Assignees
@serbanghita

Comments

@peterbo
Copy link

peterbo commented Apr 11, 2013

Hi there, I stumbled upon a problem, using Chrome on iOS. The Browser is detected as "Chrome". But since CriOS in Browser-Detection resolves to "Chrome" and you use the Browser-Name as property to get the Browser's version, no version can be detected (because it searches for Chrome/[VER] instead of CriOS/[VER]). 2 possible solutions:

  • split the userAgent detection into Chrome and CriOS or
  • merge the properties Chrome and CriOS to correctly match the version

Cheers
Peter
@ghost ghost assigned serbanghita Apr 11, 2013
@serbanghita
Copy link
Owner

@peterbo Yes you are right, I've merged all the searches under Chrome. It will be available asap

@peterbo
Copy link
Author

peterbo commented Apr 11, 2013

Thanks for the nice work!

@peterbo peterbo closed this as completed Apr 11, 2013
@peterbo peterbo reopened this Apr 11, 2013
@serbanghita
Copy link
Owner

Done! Check master or 2.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serbanghita serbanghita

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@peterbo @serbanghita and others