Skip to content
This repository has been archived by the owner on May 20, 2024. It is now read-only.

Update GCC/Clang versions #15

Closed
zamazan4ik opened this issue Jun 12, 2020 · 2 comments
Closed

Update GCC/Clang versions #15

zamazan4ik opened this issue Jun 12, 2020 · 2 comments

Comments

@zamazan4ik
Copy link

Hi!

Seems like comparison isn't fair enough since you use outdated C++ compilers but quite new Rust compiler. Please update to the latest GCC10/Clang10.

Thank you.

@dtolnay
Copy link
Member

dtolnay commented Jun 13, 2020

Thanks, indeed I hadn't updated the C++ numbers since 2016 (when those compiler version were both brand new).

@dtolnay
Copy link
Member

dtolnay commented Jun 13, 2020

FYI @Licenser since it appears now rapidjson's stringify of citm_catalog.json is now some 2x faster than simd-json's; maybe this is actionable to you.

Here is the repro:

  # simd-json
$ CARGO_INCREMENTAL=0 RUSTFLAGS='-C codegen-units=1 -C target-cpu=native' cargo build --release --no-default-features --features stringify-dom,lib-simd-json,file-citm-catalog
$ target/release/json-benchmark

  # rapidjson
$ git fetch origin refs/pull/16/head  # https://github.com/serde-rs/json-benchmark/commit/e07d3e754e1efcbfd2b488614de0d02285ab9e45
$ git checkout FETCH_HEAD
$ cd cpp
$ make
$ ./benchmark

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants