Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entry API to the Map object #236

Closed
mathstuf opened this issue Jan 31, 2017 · 6 comments · Fixed by #263
Closed

Entry API to the Map object #236

mathstuf opened this issue Jan 31, 2017 · 6 comments · Fixed by #263
Assignees
@dtolnay
Labels
enhancement

Comments

@mathstuf
Copy link

This API is really nice and would be great to have exposed on the type.
@dtolnay
Copy link
Member

dtolnay commented Jan 31, 2017

I agree. Would you be interested in implementing this yourself?

@dtolnay
Copy link
Member

dtolnay commented Jan 31, 2017

Actually first we would need to fix contain-rs/linked-hash-map#5.

@mathstuf
Copy link
Author

I could; not sure of a timeline though.

dtolnay referenced this issue in Byron/google-apis-rs Feb 4, 2017
@Byron
fix(tests): use new serde map implementation
1323d0d 
No fun, this one.
@dtolnay dtolnay mentioned this issue Feb 4, 2017
Closed
@dtolnay
Copy link
Member

dtolnay commented Feb 15, 2017

Waiting on a linked-hash-map release - contain-rs/linked-hash-map#77.

@dtolnay dtolnay self-assigned this Feb 21, 2017
@dtolnay dtolnay mentioned this issue Feb 21, 2017
Merged
@dtolnay
Copy link
Member

dtolnay commented Feb 21, 2017

I released this in serde_json 0.9.8: Map::entry

@mathstuf
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtolnay dtolnay

Labels
enhancement
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add entry API and expose map module serde-rs/json
2 participants
@mathstuf @dtolnay