NonZero constructor now returns Option #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I filed #1004 to follow up on AppVeyor. |
3 tasks
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Sep 18, 2017
Make pipeline ids non-zero so that optional ids take no extra space <!-- Please describe your changes on the following line: --> Use the NonZero trait to reduce space usage of `Option<PipelineId>`. This needs a bump of serde to get serde-rs/serde#1003. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] There are tests for these changes OR <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18523) <!-- Reviewable:end -->
aethanyc
pushed a commit
to aethanyc/gecko-dev
that referenced
this pull request
Sep 19, 2017
… take no extra space (from asajeffrey:pipeline-id-nonzero); r=mbrubeck <!-- Please describe your changes on the following line: --> Use the NonZero trait to reduce space usage of `Option<PipelineId>`. This needs a bump of serde to get serde-rs/serde#1003. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] There are tests for these changes OR <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 7256a05d74596269ca50dd42888b790016ff25af
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Sep 19, 2017
… take no extra space (from asajeffrey:pipeline-id-nonzero); r=mbrubeck <!-- Please describe your changes on the following line: --> Use the NonZero trait to reduce space usage of `Option<PipelineId>`. This needs a bump of serde to get serde-rs/serde#1003. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] There are tests for these changes OR <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 7256a05d74596269ca50dd42888b790016ff25af --HG-- rename : servo/tests/unit/layout/lib.rs => servo/tests/unit/msg/lib.rs extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear extra : subtree_revision : 6f4bbc1cbabc26a3eec40379e34b99b4521b314d
xeonchen
pushed a commit
to xeonchen/gecko-cinnabar
that referenced
this pull request
Sep 19, 2017
… take no extra space (from asajeffrey:pipeline-id-nonzero); r=mbrubeck <!-- Please describe your changes on the following line: --> Use the NonZero trait to reduce space usage of `Option<PipelineId>`. This needs a bump of serde to get serde-rs/serde#1003. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] There are tests for these changes OR <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 7256a05d74596269ca50dd42888b790016ff25af
JerryShih
pushed a commit
to JerryShih/gecko-dev
that referenced
this pull request
Sep 20, 2017
… take no extra space (from asajeffrey:pipeline-id-nonzero); r=mbrubeck <!-- Please describe your changes on the following line: --> Use the NonZero trait to reduce space usage of `Option<PipelineId>`. This needs a bump of serde to get serde-rs/serde#1003. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] There are tests for these changes OR <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 7256a05d74596269ca50dd42888b790016ff25af
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
… take no extra space (from asajeffrey:pipeline-id-nonzero); r=mbrubeck <!-- Please describe your changes on the following line: --> Use the NonZero trait to reduce space usage of `Option<PipelineId>`. This needs a bump of serde to get serde-rs/serde#1003. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] There are tests for these changes OR <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 7256a05d74596269ca50dd42888b790016ff25af UltraBlame original commit: 488548b1af4ac6ea97ddcb192d7edd14877751a0
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 2, 2019
… take no extra space (from asajeffrey:pipeline-id-nonzero); r=mbrubeck <!-- Please describe your changes on the following line: --> Use the NonZero trait to reduce space usage of `Option<PipelineId>`. This needs a bump of serde to get serde-rs/serde#1003. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] There are tests for these changes OR <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 7256a05d74596269ca50dd42888b790016ff25af UltraBlame original commit: 488548b1af4ac6ea97ddcb192d7edd14877751a0
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 2, 2019
… take no extra space (from asajeffrey:pipeline-id-nonzero); r=mbrubeck <!-- Please describe your changes on the following line: --> Use the NonZero trait to reduce space usage of `Option<PipelineId>`. This needs a bump of serde to get serde-rs/serde#1003. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] There are tests for these changes OR <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> Source-Repo: https://github.com/servo/servo Source-Revision: 7256a05d74596269ca50dd42888b790016ff25af UltraBlame original commit: 488548b1af4ac6ea97ddcb192d7edd14877751a0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1002.