Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serde Apache License is Not Filled In #1939

Closed
Alexei-B opened this issue Dec 30, 2020 · 3 comments
Closed

Serde Apache License is Not Filled In #1939

Alexei-B opened this issue Dec 30, 2020 · 3 comments

Comments

@Alexei-B
Copy link

Yo you forgot to fill the boilerplate to your license in! 😛
https://github.com/serde-rs/serde/blob/master/LICENSE-APACHE

image
@dtolnay
Copy link
Member

dtolnay commented Dec 30, 2020

We do not use boilerplate notices in source files because it is not a requirement for effecting the Apache license. Refer to rust-lang/rust#43498 or rust-lang/rust#57108.

The snippet in LICENSE-APACHE itself (as opposed to source files) is not intended to be modified.

@dtolnay dtolnay closed this as completed Dec 30, 2020
@Alexei-B
Copy link
Author

Alexei-B commented Dec 30, 2020 •
edited
Loading

Fair enough seems strange when you read it but that works. Not sure the appendix is actually part of the license but I guess it could be viewed as such, sure.

@dtolnay
Copy link
Member

dtolnay commented Dec 30, 2020

Not sure the appendix is actually part of the license but I guess it could be viewed as such, sure.

The appendix is not part of the license. It instructs the recipient how to apply the terms and conditions of the license to their work should they choose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Alexei-B @dtolnay