Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in 1.0.158 and 1.0.157 with diesel_derives #2412

Closed
Razican opened this issue Mar 20, 2023 · 2 comments
Closed

Regression in 1.0.158 and 1.0.157 with diesel_derives #2412

Razican opened this issue Mar 20, 2023 · 2 comments

Comments

@Razican
Copy link

Razican commented Mar 20, 2023

When getting an automatic dependency patchiing PR in a private project, diesel_derives fails to compile. This happened with 1.0.157 and 1.0.158 didn't solve the issue:

      Running `rustc --crate-name serde /builds/service-collider/collider/target/.cargo/registry/src/github.com-1ecc6299db9ec823/serde-1.0.158/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type lib --emit=dep-info,metadata,link -C embed-bitcode=no -C debuginfo=2 --cfg 'feature="default"' --cfg 'feature="derive"' --cfg 'feature="serde_derive"' --cfg 'feature="std"' -C metadata=001d77b17aa35b25 -C extra-filename=-001d77b17aa35b25 --out-dir /builds/service-collider/collider/target/debug/deps -L dependency=/builds/service-collider/collider/target/debug/deps --extern serde_derive=/builds/service-collider/collider/target/debug/deps/libserde_derive-95cf704dc40d5d16.so --cap-lints allow -C target-feature=-crt-static`
error[E0277]: the trait bound `FieldAttr: ToTokens` is not satisfied
   --> /builds/service-collider/collider/target/.cargo/registry/src/github.com-1ecc6299db9ec823/diesel_derives-2.0.1/src/attrs.rs:143:18
    |
143 | impl Spanned for FieldAttr {
    |                  ^^^^^^^^^ the trait `ToTokens` is not implemented for `FieldAttr`
    |
    = help: the following other types implement trait `ToTokens`:
              &'a T
              &'a mut T
              Abi
              Abstract
              AndAnd
              AndEq
              AngleBracketedGenericArguments
              Arm
            and 312 others
    = note: required for `FieldAttr` to implement `quote::spanned::private::Sealed`
note: required by a bound in `quote::spanned::Spanned`
   --> /builds/service-collider/collider/target/.cargo/registry/src/github.com-1ecc6299db9ec823/quote-1.0.26/src/spanned.rs:6:20
    |
6   | pub trait Spanned: private::Sealed {
    |                    ^^^^^^^^^^^^^^^ required by this bound in `Spanned`
error[E0277]: the trait bound `StructAttr: ToTokens` is not satisfied
   --> /builds/service-collider/collider/target/.cargo/registry/src/github.com-1ecc6299db9ec823/diesel_derives-2.0.1/src/attrs.rs:242:18
    |
242 | impl Spanned for StructAttr {
    |                  ^^^^^^^^^^ the trait `ToTokens` is not implemented for `StructAttr`
    |
    = help: the following other types implement trait `ToTokens`:
              &'a T
              &'a mut T
              Abi
              Abstract
              AndAnd
              AndEq
              AngleBracketedGenericArguments
              Arm
            and 312 others
    = note: required for `StructAttr` to implement `quote::spanned::private::Sealed`
note: required by a bound in `quote::spanned::Spanned`
   --> /builds/service-collider/collider/target/.cargo/registry/src/github.com-1ecc6299db9ec823/quote-1.0.26/src/spanned.rs:6:20
    |
6   | pub trait Spanned: private::Sealed {
    |                    ^^^^^^^^^^^^^^^ required by this bound in `Spanned`
For more information about this error, try `rustc --explain E0277`.
error: could not compile `diesel_derives` due to 2 previous errors
Caused by:
  process didn't exit successfully: `rustc --crate-name diesel_derives /builds/service-collider/collider/target/.cargo/registry/src/github.com-1ecc6299db9ec823/diesel_derives-2.0.1/src/lib.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type proc-macro --emit=dep-info,link -C prefer-dynamic -C embed-bitcode=no -C debuginfo=2 --cfg 'feature="32-column-tables"' --cfg 'feature="default"' --cfg 'feature="postgres"' -C metadata=155250df974e5e32 -C extra-filename=-155250df974e5e32 --out-dir /builds/service-collider/collider/target/debug/deps -L dependency=/builds/service-collider/collider/target/debug/deps --extern proc_macro_error=/builds/service-collider/collider/target/debug/deps/libproc_macro_error-ccd0a3ed2dfa69f7.rlib --extern proc_macro2=/builds/service-collider/collider/target/debug/deps/libproc_macro2-47ffa170bd6da30d.rlib --extern quote=/builds/service-collider/collider/target/debug/deps/libquote-b71b76cd6da69504.rlib --extern syn=/builds/service-collider/collider/target/debug/deps/libsyn-70e053ded61521dd.rlib --extern proc_macro --cap-lints allow -C target-feature=-crt-static` (exit status: 1)
warning: build failed, waiting for other jobs to finish...
@oli-obk
Copy link
Member

oli-obk commented Mar 20, 2023

I don't think this is serde-related? diesel_derives recently got a patch looking related: diesel-rs/diesel#3543 Try updating your diesel_derives dependency.

@Razican
Copy link
Author

Razican commented Mar 20, 2023

I don't think this is serde-related? diesel_derives recently got a patch looking related: diesel-rs/diesel#3543 Try updating your diesel_derives dependency.

Indeed! Good catch! I'm closing the issue. Thank you!

@Razican Razican closed this as completed Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants