Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share deserialize_with wrappers between visit_seq and visit_map #420

Closed
dtolnay opened this issue Jul 5, 2016 · 1 comment
Closed

Share deserialize_with wrappers between visit_seq and visit_map #420

dtolnay opened this issue Jul 5, 2016 · 1 comment
Assignees
@dtolnay
Labels
derive wontfix

Comments

@dtolnay
Copy link
Member

dtolnay commented Jul 5, 2016

Currently a struct with #[serde(deserialize_with="...")] on a field will generate two identical wrappers to call the deserialize_with function - one in visit_seq and one in visit_map. We should share the same wrapper to speed up compilation of the generated code.
@dtolnay dtolnay added the derive label Jul 5, 2016
@dtolnay dtolnay self-assigned this Jul 5, 2016
@dtolnay dtolnay added the wontfix label Jan 7, 2017
@dtolnay
Copy link
Member Author

dtolnay commented Jan 7, 2017

I don't think this is worth the complexity it would require in serde_codegen.

@dtolnay dtolnay closed this as completed Jan 7, 2017
@indiv0 indiv0 mentioned this issue May 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtolnay dtolnay

Labels
derive wontfix
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dtolnay