Fix #816 - adjacently-tagged enums honor deny_unknown_fields #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtolnay
reviewed
Apr 27, 2017
| @@ -751,6 +751,31 @@ fn test_adjacently_tagged_enum() { | |||
| ], | |||
| ); | |||
|
|
|||
| // unit with excess content (f, g, h) | |||
| assert_de_tokens( | |||
There was a problem hiding this comment.
Please add a test that checks the message when an unknown field is denied. See the tests in this file that use assert_de_tokens_error.
There was a problem hiding this comment.
Done. Also have success case test for deny_unknown_fields
| @@ -795,9 +795,19 @@ fn deserialize_adjacently_tagged_enum( | |||
|
|
|||
| let expecting = format!("adjacently tagged enum {}", params.type_name()); | |||
| let type_name = cattrs.name().deserialize_name(); | |||
| let deny_unknown_fields = cattrs.deny_unknown_fields(); | |||
|
|
|||
| /// If unknown fields are allowed, we pick the visitor that can | |||
There was a problem hiding this comment.
Please replace these doc comments with ordinary // comments. This makes it look like they somehow end up in rustdoc.
There was a problem hiding this comment.
In my IDE (VSCode), /// comments on local vars are supposed to be showing up, like with JSDoc comments on private functions or members.
serde_derive/src/de.rs
Outdated
| } else { | ||
| quote! { | ||
| { | ||
| let mut __rk : Option<_serde::private::de::TagOrContentField> = None; |
There was a problem hiding this comment.
Please use absolute paths for Option and None (below as well) to avoid bugs like #737 (comment).
* Added error test when deny_unknown_fields enabled * Fixed next_relevant_key to use absolute paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation includes happy-path test; wasn't sure where to put the test for
deny_unknown_fields, but was able to verify that locally in another crate.#816